search

cidgoh / DataHarmonizer

A standardized browser-based spreadsheet editor and validator that can be run offline and locally, and which includes templates for SARS-CoV-2 and Monkeypox sampling data. This project, created by the Centre for Infectious Disease Genomics and One Health (CIDGOH), at Simon Fraser University, is now an open-source collaboration with contributions from the National Microbiome Data Collaborative (NMDC), the LinkML development team, and others.
MIT License
97 stars 27 forks source link

Update to Handsontable 13.0.1 to enable batch() quick render. #409

Closed ddooley closed 1 year ago

ddooley commented 1 year ago

2ndary code changes required for handsontable upgrade below:

.alter('insert_row'...) -> .alter('insert_row_below' ...

hiddenColsPlugin.showColumns(hiddenColsPlugin.hiddenColumns); -> 
const hidden = hiddenColsPlugin.getHiddenColumns(); 
etc.

Remaining problem is with flatpickr datepicker?

kennethbruskiewicz commented 1 year ago

Remaining problem is with flatpickr datepicker?

I'll close the PR since it looks to me like a straightforward upgrade, but could you explain this issue?

ddooley commented 1 year ago

Hi Kenneth - issue is explained in https://github.com/cidgoh/DataHarmonizer/issues/408 . It turns out solution may not have required a Handsontable upgrade but I did it anyways (and Patrick was ok with upgrade).

ddooley commented 1 year ago

Also it does introduce a new property for a loaded schema template: "this.fields = this.getFields(); " . This means code can be a bit more efficient elsewhere by replacing .getFields() calls with this.fields references.