LinkML scheme should have min/max values as integers rather than string representation of integers

cidgoh / DataHarmonizer

A standardized browser-based spreadsheet editor and validator that can be run offline and locally, and which includes templates for SARS-CoV-2 and Monkeypox sampling data. This project, created by the Centre for Infectious Disease Genomics and One Health (CIDGOH), at Simon Fraser University, is now an open-source collaboration with contributions from the National Microbiome Data Collaborative (NMDC), the LinkML development team, and others.

MIT License

97 stars 27 forks source link

LinkML scheme should have min/max values as integers rather than string representation of integers #437

Closed ddooley closed 2 months ago

ddooley commented 5 months ago

linkml-validate code fails right now if schema has "1234" string numbers, rather than 1234 numbers directly, i.e. a DH schema with

minimum_value: "0"
maximum_value: "130"

whereas this succeeds:

minimum_value: 0
maximum_value: 130

So a small fix to DH tabular_to_schema.py achieves this.

ddooley commented 5 months ago

However, currently numeric fields are being saved as strings. For validation to work, we have to ensure numeric values are saved as unquoted values.

ddooley commented 2 months ago

This is now resolved in tabular_to_schema.py