cidgoh / geem

Genomic Epidemiology Entity Mart
Creative Commons Attribution 4.0 International
3 stars 1 forks source link

contrib.auth.views.login(), logout() deprecated #29

Closed ivansg44 closed 5 years ago

ivansg44 commented 5 years ago

contrib.auth.views.login(), logout() were deprecated in Django 2.1.

As a result, I ran into issues when creating a development server. Here are the changes I made locally to correct the issue, at lines 33-34 of geem/urls.py:

@@ -30,6 +30,6 @@ urlpatterns = [
     #path('data/private/', views.private_packages),
     #path('data/private/<file_name>/', views.private_package),

-    path('accounts/login', auth_views.login, name='login', kwargs={'template_name': 'geem/login.html'}),
-    path('accounts/logout', auth_views.logout, name='logout', kwargs={'next_page': reverse_lazy('portal')}),
+    path('accounts/login', auth_views.LoginView.as_view(template_name='geem/login.html'), name='login'),
+    path('accounts/logout', auth_views.LogoutView.as_view(next_page=reverse_lazy('portal')), name='logout'),
 ]

This allowed me to set up the development server using Docker.

ddooley commented 5 years ago

Good stuff. I've implemented in my branch; and closed.