Error caused by non-numeric windspeed

MattDoubleYou commented 1 month ago

System Health details

System Information

version	core-2024.9.3
installation_type	Home Assistant OS
dev	false
hassio	true
docker	true
user	root
virtualenv	false
python_version	3.12.4
os_name	Linux
os_version	6.6.46-haos
arch	x86_64
timezone	Pacific/Auckland
config_dir	/config

Home Assistant Community Store

Home Assistant Cloud

Home Assistant Supervisor

Dashboards

Recorder

Checklist

[X] I have filled out the issue template to the best of my ability.
[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
[X] This issue is not a duplicate issue of any previous issues..

Describe the issue

this_hour["wind"]["speed"] can equal 'NA', when a float is expected.

The result is that the hourly forecast doesn't display on the weather.home card and any actions using the hourly forecast return an 'unknown error'.

Screenshot_2024-09-28-08-13-05-59_c3a231c25ed346e59462e84656a70e50~2 Screenshot_2024-09-28-08-13-19-94_c3a231c25ed346e59462e84656a70e50~2

Reproduction steps

Requires forecast weather conditions where Metservice is returning 'NA' for a forecast windspeed
In HA, go to DevTools>Actions and enter details to run Weather: Get forecasts for the Metservice integration.
Choose the Hourly forecast type
Note that an 'Unknown Error' is returned
Check the logs to view error details

Debug logs

Logger: homeassistant.components.websocket_api.http.connection
Source: custom_components/metservice_weather/weather.py:358
integration: Home Assistant WebSocket API (documentation, issues)
First occurred: September 27, 2024 at 6:49:13 AM (46 occurrences)
Last logged: 8:27:26 AM
...
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/decorators.py", line 28, in _handle_async_response
    await func(hass, connection, msg)
  File "/usr/src/homeassistant/homeassistant/components/weather/websocket_api.py", line 103, in ws_subscribe_forecast
    await entity.async_update_listeners({forecast_type})
  File "/usr/src/homeassistant/homeassistant/components/weather/__init__.py", line 968, in async_update_listeners
    native_forecast_list: list[Forecast] | None = await getattr(
                                                  ^^^^^^^^^^^^^^
  File "/config/custom_components/metservice_weather/weather.py", line 316, in async_forecast_hourly
    return self.forecast_hourly
           ^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/metservice_weather/weather.py", line 358, in forecast_hourly
    if float(this_hour["wind"]["speed"]) > 40:
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: could not convert string to float: 'NA'

Diagnostics dump

No response

ciejer commented 3 weeks ago

This should be resolved in 0.7 - please advise if any ongoing issues. Sorry for the delay!

MattDoubleYou commented 2 weeks ago

This should be resolved in 0.7 - please advise if any ongoing issues. Sorry for the delay!

Thanks for this very useful integration!

ciejer / metservice-weather