search

ciel-lang / CIEL

CIEL Is an Extended Lisp. Scripting with batteries included.
http://ciel-lang.org
346 stars 16 forks source link

Install quicklisp on CI for void linux binaries. #33

Closed cinerion closed 1 year ago

cinerion commented 1 year ago

Since quicklisp has been updated there is no longer a need to manually install dependencies.

Also, I have moved the quicklisp installation step from the docker image creation (which is now done monthly through github actions so it doesn't get too stale in the future) to the void linux build job on gitlab CI in this repo.

I could have updated the quicklisp dist, but to keep debian's and void's build jobs somewhat uniform I think it might be better to just install quicklisp through this repo's CI.

vindarel commented 1 year ago

Is it normal to still have the "ql-deps" line?

# Install some Quicklisp dependencies.
ql-deps:

# Install some sytem dependencies.
debian-deps:
    apt-get install -y libmagic-dev libinotifytools0

and you didn't remove it from the .gitlab-ci.yml?

However I am fine by keeping this target for a few more months in the Makefile, it might be useful to some (like another me, I don't always update Quicklisp straight away :roll_eyes: )

In that case adding a comment is necessary.

Thanks!

cinerion commented 1 year ago

You're right, it might be best to delay this merge for the time being, and maybe reconsider in 1 or 2 months. I will discard that commit and make the PR only about installing quicklisp for the void job.