search

ciemss / pyciemss

Causal and probabilistic reasoning with continuous time dynamical systems
Other
17 stars 6 forks source link

Alter and bugfix for service integration #443

Closed fivegrant closed 8 months ago

SamWitty commented 9 months ago

Thanks for this PR @fivegrant . It looks like the tests are failing because the changes to the output of calibrate haven't been propagated through all of the tests. For example, see: https://github.com/ciemss/pyciemss/blob/44055b5c906d768410f989d3de89672e111a27b8/tests/test_interfaces.py#L213C4-L213C4

In addition, could you address the linting error by calling make format from the root directory to automatically format the files and tests, and then run make lint to check (and debug) types? Thanks!

fivegrant commented 9 months ago

Good points @SamWitty . I'll make sure to lint and fix tests. I'm going to keep this PR around until the service refactor is ready just in case I need to make any more changes.

fivegrant commented 9 months ago

@SamWitty I went ahead and removed the WIP label. I'll just reopen new PRs as needed. This current PR should be good to go.