search

ciemss / pyciemss

Causal and probabilistic reasoning with continuous time dynamical systems
Other
12 stars 4 forks source link

Sa load data tests #453

Closed sabinala closed 5 months ago

sabinala commented 6 months ago

This PR adds a notebook and makes changes to the load_data function in pyciemss/integration_utils/observation.py so that errors with missing or badly formatted data may be handled more smoothly.

Closes #434 And the branch 434-add-tests-for-load_data-to-robustly-handle-typical-csv-issues created from this issue can be closed as well. See comment in #434.

review-notebook-app[bot] commented 6 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

SamWitty commented 5 months ago

@sabinala , what is the status of this PR? Can it be closed?

sabinala commented 5 months ago

@SamWitty yes, this PR can be closed. I started working on this issue (https://github.com/ciemss/pyciemss/issues/454) here first, but then got derailed when I realized that calibrate wasn't working with data mapped to observables.