Closed sabinala closed 6 months ago
@sabinala , as discussed in our call yesterday, could you please change these assertions to the following:
if condition:
raise ValueError("description")
@djinnome I've changed the assert
statement to an if
statement that raises a ValueError
, and now this PR is ready for review.
Hi @sabinala please add a unit test in test_interfaces.py
that asserts that providing a float
, or negative int
or 0
or tensor(int)
raises an error when used as input to the num_samples
parameter, and providing a positive int
does not raise an error.
@djinnome unit tests for calibrate
error messages are in their own file in tests
, and all tests are passing here too.
This PR adds an assert statement (see code below) in
calibrate
that will give the error message: "num_iterations must be a positive integer." ifnum_iterations
is not a positive integer.Closes #456