search

ciemss / pyciemss

Causal and probabilistic reasoning with continuous time dynamical systems
Other
17 stars 6 forks source link

Adding support for ensemble output format #570

Closed anirban-chaudhuri closed 5 months ago

review-notebook-app[bot] commented 5 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

sabinala commented 5 months ago

Why are all of the checks failing...oh no! We should fix that before merging.

sabinala commented 5 months ago

Especially the linting? When I enter make format it says all of the files are fine.

SamWitty commented 5 months ago

Especially the linting? When I enter make format it says all of the files are fine.

@sabinala , make format does not automatically resolve typing inconsistencies, which is a good thing. Use make lint locally to see if the linter would pass.

SamWitty commented 5 months ago

@anirban-chaudhuri , I believe I resolved the current issues causing failing test in #572 . I created a separate PR because that contribution was independent of this one, although it is blocking.