ciena-blueplanet / dagre

Directed graph renderer for javascript
MIT License
36 stars 13 forks source link

Fix `export` to be `export default` in src/position/bk.js. #12

Closed jemc closed 7 years ago

jemc commented 7 years ago

This project uses semver, please check the scope of this pr:

CHANGELOG

Fix export to be export default in src/position/bk.js.

jemc commented 7 years ago

Before this change, I could not run npm test. When I tried to do so, I saw the following error output:

SyntaxError: src/position/bk.js: `addConflict` has already been exported. Exported identifiers must be unique. (395:2)
  393 | 
  394 | export {
> 395 |   addConflict,
      |   ^
  396 |   alignCoordinates,
  397 |   balance,
  398 |   buildBlockGraph,

npm ERR! Linux 4.4.11-200.fc22.x86_64
npm ERR! argv "/home/jemc/1/code/tarx/node-v6.9.1-linux-x64/bin/node" "/home/jemc/1/code/tarx/node-v6.9.1-linux-x64/bin/npm" "run" "build"
npm ERR! node v6.9.1
npm ERR! npm  v4.0.2
npm ERR! code ELIFECYCLE
npm ERR! ciena-dagre@1.0.0 build: `babel src -d lib --presets es2015 --plugins add-module-exports`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the ciena-dagre@1.0.0 build script 'babel src -d lib --presets es2015 --plugins add-module-exports'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the ciena-dagre package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     babel src -d lib --presets es2015 --plugins add-module-exports
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs ciena-dagre
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls ciena-dagre
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /home/jemc/1/code/gitx/dagre/npm-debug.log

npm ERR! Linux 4.4.11-200.fc22.x86_64
npm ERR! argv "/home/jemc/1/code/tarx/node-v6.9.1-linux-x64/bin/node" "/home/jemc/1/code/tarx/node-v6.9.1-linux-x64/bin/npm" "run" "utest"
npm ERR! node v6.9.1
npm ERR! npm  v4.0.2
npm ERR! code ELIFECYCLE
npm ERR! ciena-dagre@1.0.0 utest: `npm run build && istanbul cover _mocha -- --recursive tests`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the ciena-dagre@1.0.0 utest script 'npm run build && istanbul cover _mocha -- --recursive tests'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the ciena-dagre package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run build && istanbul cover _mocha -- --recursive tests
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs ciena-dagre
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls ciena-dagre
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /home/jemc/1/code/gitx/dagre/npm-debug.log
coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 5017794459bc12e7d52caf13baae99c2eaa1bf9e on jemc:fix/duplicate-exports into on ciena-blueplanet:master.

jemc commented 7 years ago

I've now also added a commit to update some dev dependency packages, to satisfy the "bitHound - Dependencies" CI task.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 0bfe874e2d2ad459d4e26fe51f24ff8cf5affa84 on jemc:fix/duplicate-exports into on ciena-blueplanet:master.

jemc commented 7 years ago

@sandersky Thanks for the comment - I've updated the commit, the PR title, and the changelog entry.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 539dc95c35ac8524de4b14091d089797ddf2c1b3 on jemc:fix/duplicate-exports into on ciena-blueplanet:master.

sandersky commented 7 years ago

:+1: