search

ciena-blueplanet / dagre

Directed graph renderer for javascript
MIT License
36 stars 13 forks source link

How to build? #21

Closed jomeier closed 6 years ago

jomeier commented 7 years ago

Hi,

I installed your fork of dagre with npm install --ignore-scripts as written in the README.

But how do I build it? There is no dist folder.

Thx and best regards,

Josef

notmessenger commented 7 years ago

These are the instructions from the forked repo - https://github.com/cpettitt/dagre/wiki#source-build. Hopefully they provide the information you need.

joeframbach commented 7 years ago

Sure, but you removed the makefile. https://github.com/ciena-blueplanet/dagre/commit/a1ec72cdabbd657126918d594b4426db016bb199#diff-b67911656ef5d18c4ae36cb6741b7965L1

sophypal commented 7 years ago

I'm not sure if the original intention of this fork was to be exactly like the original dagre and I apologize if anyone mislead you to believe that. Our team has embraced ES6 and we're using frameworks that can transpile it for us. We're using Ember but I'm pretty sure Webpack can be used to import ES6 modules. If you happen to be using Ember, you can use https://github.com/ciena-blueplanet/ember-dagre which pipes this in to Ember without needing to shim it yourself. Of course, we'll accept PRs if anyone wants to attempt to try this out with Webpack and is willing to create useful instructions.

joeframbach commented 7 years ago

I was able to build dist manually:

mkdir dist
yarn build
yarn global add browserify uglifyify
browserify dist | uglifyify > dist/dagre.min.js

On Aug 16, 2017 10:59 PM, "Sophy Pal" notifications@github.com wrote:

I'm not sure if the original intention of this fork was to be exactly like the original dagre and I apologize if anyone mislead you to believe that. Our team has embraced ES6 and we're using frameworks that can transpile it for us. We're using Ember but I'm pretty sure Webpack can be used to import ES6 modules. If you happen to be using Ember, you can use https://github.com/ciena-blueplanet/ember-dagre which pipes this in to Ember without needing to shim it yourself. Of course, we'll accept PRs if anyone wants to attempt to try this out with Webpack and is willing to create useful instructions.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ciena-blueplanet/dagre/issues/21#issuecomment-322976529, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB7-JYMuu_Qv7WTgr3cGtpi_kZYnxE1ks5sY9a3gaJpZM4ObB0e .

jroitgrund commented 6 years ago

I think this is a mistake. You are effectively preventing anyone from using your package if they don't:

a) use a transpiler (this is still very common) b) transpile their dependencies (I'm not aware of any existing use case for this)

What benefit are you getting from publishing ES6 code besides debugability, which you could get by publishing source maps?