search

ciena-blueplanet / dagre

Directed graph renderer for javascript
MIT License
36 stars 13 forks source link

Use transpiled files in distribution #25

Closed jroitgrund closed 6 years ago

jroitgrund commented 6 years ago

The current distribution references the source files rather than the transpiled files. This means that importing this module into a non-transpiled ES5 project breaks it completely.

This project uses semver, please check the scope of this pr:

CHANGELOG

We now distribute ES5 code rather than the ESNext source, so that this library can be used as is instead of requiring a transpiler.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 98.784% when pulling 7a7bfa9971fa13407491f51f3937bfc02518030c on jroitgrund:patch-1 into 87edbc0f1498458dec475b1c9174cfa57d64f76f on ciena-blueplanet:master.

jroitgrund commented 6 years ago

Is there a reason you closed this? Right now I have to use this hack:

"prebuild": "sed -i. 's/src/lib/g' node_modules/ciena-dagre/index.js"

In general I'm not aware of any projects that transpile their dependencies, and shipping ES5 code is the standard on NPM. Are there any benefits to shipping ES6 code that you couldn't get with source maps?