ciena-blueplanet / dagre

Directed graph renderer for javascript
MIT License
36 stars 13 forks source link

Fold improvements back into dagre? #26

Closed cpettitt closed 6 years ago

cpettitt commented 6 years ago

We're built an organization around dagre and are resuming development. Would you be OK with us pulling some of your improvements back upstream, such as your work on lodash 4 support? Any interest in having a committer in the org for the upstream project?

notmessenger commented 6 years ago

We are absolutely okay with you pulling some of our improvements back upstream. Depending on how you approach the work it would be nice to know which ones were and were not pulled in so we can (consider) deprecating this fork to reduce confusion in the community about which one to use (as well as within our organization about into which repo to submit changes).

As far as having a committer in the org for the upstream project I do not believe the individual who primarily created the fork and a majority of the modifications - @sandersky - is using this project anymore but I could be wrong. @sophypal - Do you have any interest? If these specific individuals do not I may reach out in the future if the need arises if that is okay.

Thank you for reaching out!

cpettitt commented 6 years ago

Sounds great. Thanks for sharing your contributions. I'll follow up with what gets pulled upstream. I appreciate you keeping us in mind w.r.t. committers - I'd love to get a few regular users in a position to influence the project going forward.

sandersky commented 6 years ago

I'm not using the project anymore but would love seeing the changes I made pulled back into the upstream project.

cpettitt commented 6 years ago

I've added support for lodash 4 to dagre. I was not able to cherry-pick all of the patches that @sandersky did due to moved files, but linked the original patches in the new ones when this was the case. Also credited @sandersky in the package.json.

I did not pull in the changes to the build / packaging system as the current build system is consistent across dagre-d3, graphlib, graphlib-dot. I believe that is the biggest difference between the repos now.

Thanks @sandersky for your work on lodash 4 support!