Will solve #112 (we'll retire NightmareJS in favor of Electron)
My current work on this can be found here: Electron branch
To do:
[x] solves #112, no need to specify sizes
[x] captures images just as accurate as nightmarejs
[ ] solve testem issues Need to fix this in order to move onto electron
[x] fix issue where Electron is listed as browser but never loads testem instead the Electron comes up as Chrome and runs the tests. The electron tab will error b/c of "no testem loaded"
[ ] Fix consistency of fixed div. fixed div's text will be slightly moved when comparing base-comparison. I had this issue with all the others but solved by changing the ember-testing-container to be positioned absolutely at always display at 0,0. Problem was the content on the testing page wasn't the same as when the base image is captured (basically base image has extra text on page. U could also reproduce by moving test order after base). So this fixed div must still be affected by the additional/removed content on the page that differs from the base capture to the new one. But more-fixed doesn't have this issue and also holds fixed elements
[ ] Replace setTimeout to wait for a properly painted image(otherwise there is potential to get image of 0 bytes. Currently there is a long timeout period so this shouldn't happen currently). Likely related to https://github.com/electron/electron/issues/6426
Will solve #112 (we'll retire NightmareJS in favor of Electron)
My current work on this can be found here: Electron branch To do:
testemissues Need to fix this in order to move onto electronElectronis listed as browser but never loadstesteminstead the Electron comes up as Chrome and runs the tests. The electron tab will error b/c of "no testem loaded"fixed div.fixed div's text will be slightly moved when comparing base-comparison. I had this issue with all the others but solved by changing theember-testing-containerto be positioned absolutely at always display at0,0. Problem was the content on the testing page wasn't the same as when the base image is captured (basically base image has extra text on page. U could also reproduce by moving test order after base). So this fixed div must still be affected by the additional/removed content on the page that differs from the base capture to the new one. Butmore-fixeddoesn't have this issue and also holds fixed elementssetTimeoutto wait for a properly painted image(otherwise there is potential to get image of 0 bytes. Currently there is a long timeout period so this shouldn't happen currently). Likely related to https://github.com/electron/electron/issues/6426