ciena-blueplanet / ember-cli-visual-acceptance

MIT License

30 stars 12 forks source link

Closed EWhite613 closed 8 years ago

EWhite613 commented 8 years ago

patch

Need to test some more. I don't know why https://github.com/ciena-blueplanet/ember-cli-visual-acceptance/pull/73/files#diff-435ef62643883d72917b250165c56a8bL85 was ever there. I think it was a remanent from trying to get cross-os to work with no differences

ember-cli-visual-acceptance commented 8 years ago

EWhite613 commented 8 years ago

@sglanzer Notice PhantomJS fixed fixed image is blank. Only 'downside'

sglanzer-deprecated commented 8 years ago

Yeah, I'm good with Phantom being a second-class citizen, awesome work :)

sglanzer-deprecated commented 8 years ago

Approved

EWhite613 commented 8 years ago

Gonna hold off on merging for a bit. Need to do some tests with containers of a different size

sglanzer-deprecated commented 8 years ago

Approved

EWhite613 commented 8 years ago

@sglanzer got phantomJS to work. And got specifying the target size to work with this fix

EWhite613 commented 8 years ago

Tested core and ui with the new changes and they both work.

I'll update the core PR with the new version once this is merged

sglanzer-deprecated commented 8 years ago

Approved - so much win