ciena-blueplanet / ember-cli-visual-acceptance

MIT License
30 stars 12 forks source link

SlimerJS Seg Faults on SVG xlink:href #76

Open EWhite613 opened 8 years ago

EWhite613 commented 8 years ago

Cause: https://github.com/laurentj/slimerjs/issues/514

I mentioned in the Blog post issues of SlimerJS. Basically a You have been warned section. And also possibly lower it on our Browser recommendations (maybe even below PhantomJS, even though SlimerJS produces much more accurate images)?

Mostly listing this issue for others to be aware. As I know it does affect using SlimerJS on https://github.com/ciena-frost/ember-frost-core .

I'd imagine it affects anyone that uses svg4everybody/ember-frost-core icons or some form of xlink:href.

SlimerJS can open http://ciena-frost.github.io/ember-frost-core/#/icons, as it uses Inline Rendering, but running tests with Inline rendering does still crash if memory serves me correctly (I'll double check this)

EWhite613 commented 8 years ago

Mozilla bug created here: https://bugzilla.mozilla.org/show_bug.cgi?id=1292185

EWhite613 commented 8 years ago

Put in a PR for a fix: https://github.com/laurentj/slimerjs/pull/518

I doubt this fix will see it's way into https://github.com/graingert/slimerjs (the npm version of slimerjs). As Slimerjs will hopefully be put directly in npm https://github.com/laurentj/slimerjs/pull/515

So we'll just have to wait for the npm PR to go through or add instructions to install slimerjs on Travis/etc w/o npm

sglanzer-deprecated commented 8 years ago

Awesome, I hope that PR gets merged - it would be great to get slimer back in the mix

KevinGrandon commented 8 years ago

FYI - I've published a fork of the slimerjs package to NPM because a few of us needed it. I've also included your patch in the fork in case you want to use it. In the long term I hope to be able to discontinue using the fork and npm package assuming there's better upstream support.

NPM package: slimerjs-core@0.11.1 Npmjs: https://www.npmjs.com/package/slimerjs-core Repo: https://github.com/KevinGrandon/slimerjs

sglanzer-deprecated commented 8 years ago

@KevinGrandon you rule, the continual improvements in this area are awesome :)