ciena-blueplanet / ember-cli-visual-acceptance

MIT License
30 stars 12 forks source link

Windows is not supported #92

Closed ro0gr closed 8 years ago

ro0gr commented 8 years ago
$ node_modules\.bin\ember nb
DEPRECATION: ember-try is now included with ember-cli. Including it in your package.json is unnecessary.
events.js:141
      throw er; // Unhandled 'error' event
      ^

Error: spawn ember ENOENT
    at exports._errnoException (util.js:855:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:178:32)
    at onErrorNT (internal/child_process.js:344:16)
    at nextTickCallbackWith2Args (node.js:455:9)
    at process._tickCallback (node.js:369:17)

The reason is spawn is not able to find ember-cli executable installed into project. Also it isn't able to find ember-cli executable installed globally.

Looks like PATHEXT issue in node for Windows.

Currently I can see 2 possible options:

@EWhite613 @sglanzer your thoughts please?

EWhite613 commented 8 years ago

I think we should just use the lookup command. And then just use exec for git since those commands will be relatively short and we can just make due with the buffered output ( wait till command is finished to receive output.)

EWhite613 commented 8 years ago

Also it locks like ember-cli also uses exec for git https://github.com/ember-cli/ember-cli/blob/d8ba7dbaf77df0e7fe2daf1d153a1a5a60620143/lib/tasks/git-init.js

sglanzer-deprecated commented 8 years ago

I'm on board with the lookup command plan - getting windows support would be nice - can run IE11/Edge in a VM, but a native CI machine would be :+1:

ro0gr commented 8 years ago

Thank you for your feedback guys. I'm going to take a look at switching to 'lookupCommand' for ember commands this week.