Closed ro0gr closed 8 years ago
I think we should just use the lookup command. And then just use exec for git since those commands will be relatively short and we can just make due with the buffered output ( wait till command is finished to receive output.)
Also it locks like ember-cli also uses exec for git https://github.com/ember-cli/ember-cli/blob/d8ba7dbaf77df0e7fe2daf1d153a1a5a60620143/lib/tasks/git-init.js
I'm on board with the lookup command plan - getting windows support would be nice - can run IE11/Edge in a VM, but a native CI machine would be :+1:
Thank you for your feedback guys. I'm going to take a look at switching to 'lookupCommand' for ember commands this week.
The reason is
spawn
is not able to findember-cli
executable installed into project. Also it isn't able to findember-cli
executable installed globally.Looks like PATHEXT issue in node for Windows.
Currently I can see 2 possible options:
cross-spawn
to lookup executables in.\node_modules\.bin
so I need to install to haveember-cli
installed globallyspawn
at all except ofgit
uses cases.@EWhite613 @sglanzer your thoughts please?