Ember 2.4: tests will always fail; string validation fails if not passed a string - Githubissues

ciena-blueplanet / ember-prop-types

Improved property management for Ember apps and addons.

http://ciena-blueplanet.github.io/ember-prop-types/

MIT License

80 stars 36 forks source link

Ember 2.4: tests will always fail; string validation fails if not passed a string #139

Closed notmessenger closed 7 years ago

notmessenger commented 7 years ago

PR https://github.com/ciena-blueplanet/ember-prop-types/pull/129 introduced SafeString support. At the time the PR was submitted and the builds ran, the ember-try scenarios and travis.yml configuration did not contain a build for Ember v2.4. Subsequent to the PR being opened such a scenario was added to master which this PR did not have the changes for prior to its merging.

The code introduced in https://github.com/ciena-blueplanet/ember-prop-types/pull/129 is not compatible with Ember v2.4 (https://travis-ci.org/ciena-blueplanet/ember-prop-types/builds/260170139). This means that every run of tests from this point forward will fail. It also means that anyone using Ember v2.4 that requires a String PropType and passes something that is not a string will fail as well.