search

ciena-blueplanet / ember-prop-types

Improved property management for Ember apps and addons.
http://ciena-blueplanet.github.io/ember-prop-types/
MIT License
80 stars 36 forks source link

Can we upgrade ember-cli-babel, ember-cli, etc? #158

Open Dhaulagiri opened 6 years ago

Dhaulagiri commented 6 years ago

The most recent attempt to update this addon was reverted, are you open to revisiting this? If so I'm happy to do the leg work, I just don't want to unless I know it's something you are open to. My main reason for this is to remove the babel 5 dep here so upstream consumers like ember-block-slots aren't relying on babel 5 either.

notmessenger commented 6 years ago

Ember CLI 2.13.0 introduced the use of Babel 6. The use of Babel 6 and Babel 5 (provided by Ember CLI 2.12.3) in the same application very often results in build failures. This means that an application must either use Ember 2.12 and addons that are running Ember CLI 2.12.3 or older, or use Ember 2.13+ and addons running Ember CLI 2.13+. Unfortunately we have applications within our organization that cannot yet upgrade past Ember 2.12 so the addons we use - such as this one and all of those within the https://github.com/ciena-frost organization - are not able to be upgraded past Ember CLI 2.12.3 at this point. In the coming months we will be devising a strategy for how we are going to coordinate the upgrade efforts of these repos (either by delaying additional changes to these addons until they are all on Ember CLI 2.13+ or maintaining branches for the 47 addon repos our applications use) so that we can move this, and other, repos past Ember CLI 2.12.3 (with our desire to be to move them to the latest 3.x version).

So yes - we fully intend on upgrading this and all our other repos to the latest version of Ember CLI but unfortunately it is not something we can do at this exact time, but are planning to do so very soon (which is why the reversion you reference even had to be employed)

Dhaulagiri commented 6 years ago

@notmessenger thanks for the clarification, it's at least helpful to have more context around what is going on.

I'm curious if you can elaborate more on the specific problem you are having? My expectation and experience is that one is able to have different versions of babel transpiling things since each addon is responsible for its own transpiliation separate from the consuming app. Or is the problem that if the consuming app is on babel 5 that you run into issues with any addons using babel 6?

Dhaulagiri commented 6 years ago

Any update on this?

notmessenger commented 6 years ago

While these repositories are hosted on GitHub and are licensed as open source the reality is that they are only managed from the perspective of our organization's own internal needs. Hopefully within the next several weeks it will be determined whether we are even going to continue using this library internally (at which point it can be turned over to other maintainers who can set their own direction for the project) and if so, if and when we will undertake any upgrade efforts.

I know that this is not an ideal answer but I wanted to share with you all of the information I have about everything so that you can plan accordingly.

omairvaiyani commented 5 years ago

Can I ask what the outcome of your meeting was?