ciena-blueplanet / ember-spread

Dynamic options for dynamic components
https://ciena-blueplanet.github.io/ember-spread/
MIT License
31 stars 15 forks source link

DEPRECATION: An addon is trying to access project.nodeModulesPath. #52

Open eturino opened 6 years ago

eturino commented 6 years ago

DEPRECATION REPORT

Summary

When building with later ember 2.x, we see the following message:

DEPRECATION: An addon is trying to access project.nodeModulesPath. This is not a reliable way to discover npm modules. Instead, consider doing: require("resolve").sync(something, { basedir: project.root }). Accessed from:   new NPMDependencyVersionChecker (/PROJECT_ROOT/node_modules/ember-spread/node_modules/ember-cli-version-checker/src/npm-dependency-version-checker.js:11:33)

When building with ember 3.x we see the following message:

DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.2.8 located: ember-mat-design-mock -> ember-spread -> ember-cli-babel
DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.2.8 located: ember-mat-design-mock -> ember-spread -> ember-prop-types -> ember-cli-babel
DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.2.8 located: ember-mat-design-mock -> ember-spread -> ember-prop-types -> ember-get-config -> ember-cli-babel
DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.2.8 located: ember-mat-design-mock -> ember-spread -> ember-prop-types -> ember-string-ishtmlsafe-polyfill -> ember-cli-babel

Expected Behavior

No deprecation warnings on build

Actual Behavior

Possible Solution

It seems to be ember-cli/ember-cli-version-checker#48

Updating to ember-cli-babel 6.6 or later seems to be the solution. ember-cli-babel 5.x is deprecated.

Steps to Reproduce

$ yarn global add ember-cli

$ ember --version
ember-cli: 3.0.2
node: 8.9.1
os: darwin x64

$ ember new testing-ember-spread

$ cd testing-ember-spread

$ ember i ember-spread
npm: Installed ember-spread
DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.2.8 located: ember-mat-design-mock -> ember-spread -> ember-cli-babel
DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.2.8 located: ember-mat-design-mock -> ember-spread -> ember-prop-types -> ember-cli-babel
DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.2.8 located: ember-mat-design-mock -> ember-spread -> ember-prop-types -> ember-get-config -> ember-cli-babel
DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.2.8 located: ember-mat-design-mock -> ember-spread -> ember-prop-types -> ember-string-ishtmlsafe-polyfill -> ember-cli-babel
Installed addon package.

Context

we are trying to upgrade our app to use ember 3, and this addon is one of the few ones still to fix the deprecations.

Environment

(answer all that are applicable)

notmessenger commented 6 years ago

Thank you for this submission. We are actively working to put together an upgrade plan for this repo (we are actually looking into these exact deprecations in a branch right now) and the rest in our organization.

More information about this can be found in https://github.com/ciena-frost/ember-frost-core/issues/474 and https://github.com/ciena-blueplanet/ember-prop-types/issues/158