search

ciena-blueplanet / pr-bumper

Bump the version of an npm package based on a GitHub Pull Request
MIT License
19 stars 17 forks source link

[Feature Request] Comment on PR if missing version directive #25

Open zakhenry opened 8 years ago

zakhenry commented 8 years ago

It would be helpful for those unfamiliar with pr-bumper if it could comment on pull requests when pr-bumper check fails. Bonus if the comment could be customised in .github/PR_BUMPER_COMMENT_TEMPLATE.md

https://github.com/blog/2111-issue-and-pull-request-templates

job13er commented 8 years ago

That's a great idea, I'll try to give it a shot.

job13er commented 7 years ago

I'd like to also comment on the PR in other situations, like notifying of code coverage changes, notifying of missing #CHANGELOG section, etc.

job13er commented 7 years ago

Sadly, I haven't had much success with this, not because of the code involved, but because of the permissions. If you only have PRs from within your repo (branch to branch) it could probably work. We have it working fine in our private bitbucket, but the permissions needed for posting a comment are greater than the permissions needed to simply read the PR description, and since we can't encrypt secure tokens when building a PR build from outside the repo, I haven't been able to figure out how to let pr-bumper post comments w/o exposing credentials one wouldn't want to expose.