ciena-frost / ember-frost-bunsen

Create UIs from JSON configurations

http://ciena-frost.github.io/ember-frost-bunsen/

MIT License

20 stars 35 forks source link

Update the latest version of ember-frost-tabs. #532

Closed goforsatish closed 6 years ago

goforsatish commented 6 years ago

Overview

Update the latest version of ember-frost-tabs.

Does this PR close an existing issue?

No PR should be opened without opening an issue first. Any change needs to be discussed before proceeding.

Summary

Provide a general summary of the issue addressed in the title above Update the latest version of ember-frost-tabs.

Issue Number(s)

Which issue(s) does this PR address?

Put Closes #XXXX below to auto-close the issue that this PR addresses:

Closes #

Screenshots or recordings

Please provide screenshots or recordings if this PR is modifying the visual UI or UX.

Checklist

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have evaluated if the README.md documentation needs to be updated
[ ] I have evaluated if the /tests/dummy/ app needs to be modified
[ ] I have evaluated if DocBlock headers needed to be added or updated
[ ] I have verified that lint and tests pass locally with my changes
[ ] If a fork of a dependent package had to be made to address the issue this PR closes:
- [ ] I noted in the fork's README.md the reason the fork was created
- [ ] I have opened an upstream issue detailing what was deficient about the dependency
- [ ] I have opened an upstream PR addressing this deficiency
- [ ] I have opened an issue in this repository to track this PR and schedule the removal of the usage of the fork

Semver

This project uses semver, please check the scope of this PR:

[ ] #none#
[ ] #patch#
[ ] #minor#
[x] #major#

Examples:

NONE
- README.md changes
- test additions
- changes to files that are not used by a consuming application (.travis.yml, .gitignore, etc)
PATCH
- backwards-compatible bug fix
- nothing about how to use the code has changed
- nothing about the outcome of the code has changed (though it likely corrected it)
- changes to demo app (/tests/dummy/)
MINOR
- adding functionality in a backwards-compatible manner
- nothing about how used to use the code has changed but using it in a new way will do new things
- nothing about the outcome of the code has changed without having to first use it in a new way
- addition of new CSS selectors
- addition of new ember-hook selectors
MAJOR
- incompatible API change
- using the code how used to will cease working
- using the code how used to will have a different outcome
- any changes to CSS selector names
- any removal of CSS selectors
- any changes to ember-hook selectors
- possibly changes to test helpers (depends on the changes made)
- any changes to the dependencies entry in the package.json file

CHANGELOG

Please add a description of your change here, it will be automatically prepended to the CHANGELOG.md file.

coveralls commented 6 years ago

Coverage remained the same at ?% when pulling 207bc315167851bd0afd93d40c305aabb7877db8 on ember-frost-tabs-update into 09aaea066a4f5880aa62d54cb0bfb882bc0e09ba on master.

juwara0 commented 6 years ago

Closing this issue as it is addressed in: https://github.com/ciena-frost/ember-frost-bunsen/pull/533