ciena-frost / ember-frost-list

Breakin' down table-centric application views

http://ciena-frost.github.io/ember-frost-list

MIT License

10 stars 25 forks source link

Remove custom floor helper #150

Closed jscharf closed 4 years ago

jscharf commented 7 years ago

This project uses semver, please check the scope of this pr:

[ ] #none# - documentation fixes and/or test additions
[ ] #patch# - backwards-compatible bug fix
[ ] #minor# - adding functionality in a backwards-compatible manner
[x] #major# - incompatible API change

Notes

This project has ember-math-helpers as a dependency so a custom floor helper is no longer needed. As far as I can tell, it's only used in one place anyway, which is in the pagination template for the last page button. I tested the pagination buttons after removing these files and it still works.

Resolves #84

CHANGELOG

Remove custom floor helper

coveralls commented 7 years ago

Changes Unknown when pulling 2b6685137e3fade6b877ef7b77fecd0d07fd9717 on jscharf:remove-floor-helper into on ciena-frost:master.

notmessenger commented 7 years ago

References to floor need to be removed from tests/unit/helpers/is-lead-selection.js

notmessenger commented 7 years ago

This PR needs to be a major, not a patch. This is due to the fact that we were exporting this floor helper at the ember-frost-list/helpers/floor namespace and do not know what other consuming code may still be importing it, regardless of whether we have quit consuming it internally in this add-on.

I have made this change.

Update your changelog entry to reflect the removal of this previously-exported helper