ciena-frost / ember-frost-list

Breakin' down table-centric application views

http://ciena-frost.github.io/ember-frost-list

MIT License

10 stars 25 forks source link

fix component name issue in ember 2.8.3 #153

Closed quincyle closed 7 years ago

quincyle commented 7 years ago

Fixes #152

This project uses semver, please check the scope of this pr:

[ ] #none# - documentation fixes and/or test additions
[x] #patch# - backwards-compatible bug fix
[ ] #minor# - adding functionality in a backwards-compatible manner
[ ] #major# - incompatible API change

CHANGELOG

Fixed issue when running against 2.8.3, List can't get the valid component name to render.

coveralls commented 7 years ago

Changes Unknown when pulling 0e2446495236c10b46542ee8ade484d238b689bf on quincyle:small-view into on ciena-frost:master.

dafortin commented 7 years ago

@jscharf I will approve, but I think we should do what we discussed. Instead of checking the component name checking we should use hard coded keys for the default conversion. This will avoid checking the component name and the different version handling. @jscharf can you do another PR on Monday to fix this? Thx