ciena-frost / ember-frost-navigation

https://ciena-frost.github.io/ember-frost-navigation/
MIT License
7 stars 17 forks source link

Compatibility Upgrade - LTS #191

Closed srowhani closed 7 years ago

srowhani commented 7 years ago

This project uses semver, please check the scope of this pr:

Breaking Changes

CHANGELOG

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 88f2bae897939080d0d6c078f4f2622e71427b8e on srowhani:master into on ciena-frost:master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 88f2bae897939080d0d6c078f4f2622e71427b8e on srowhani:master into on ciena-frost:master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 88f2bae897939080d0d6c078f4f2622e71427b8e on srowhani:master into on ciena-frost:master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 91a7f26c7b9e340b8b378cc1375245a4bfcfdefa on srowhani:master into on ciena-frost:master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 91a7f26c7b9e340b8b378cc1375245a4bfcfdefa on srowhani:master into on ciena-frost:master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling d01ef80c155a332ef56304e137c2f983216e78aa on srowhani:master into on ciena-frost:master.

sglanzer-deprecated commented 7 years ago

I'd like to do a walkthrough of this so that I understand everything (just being cautious around #major changes) - can you book a meeting to discuss?

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 7a8e8fb0a579bb057fb9afd9aeeee4d53dd650de on srowhani:master into on ciena-frost:master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 3ce19715ecbf1deb218a73f0742269a9a670f77b on srowhani:master into on ciena-frost:master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 3ce19715ecbf1deb218a73f0742269a9a670f77b on srowhani:master into on ciena-frost:master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 90ee8158d8c8859e6cc1bbbfff367d424b5d48c6 on srowhani:master into on ciena-frost:master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 90ee8158d8c8859e6cc1bbbfff367d424b5d48c6 on srowhani:master into on ciena-frost:master.

sglanzer-deprecated commented 7 years ago

Approved - just looks like you might have some test issues around the removed hooks?

Approved with PullApprove

srowhani commented 7 years ago

The issues were with the new ember release candidate. Added it to allowed-failures for now, will see what I can do to address in the meantime.