ciena-frost / ember-frost-navigation

https://ciena-frost.github.io/ember-frost-navigation/
MIT License
7 stars 17 forks source link

Added ability to specify icon svgs as links #221

Closed TheOtherDude closed 6 years ago

TheOtherDude commented 6 years ago

This project uses semver, please check the scope of this pr:

CHANGELOG

notmessenger commented 6 years ago

I will have to do more digging into all of these moving pieces to be able to answer this question for myself, but can't the consumer create an icon pack rather than needing these changes to be made? Just exploring the need for the changes...

job13er commented 6 years ago

@notmessenger Let me explain the use-case and why I don't think an icon-pack will work for us.

We have an API that provides a list of navigation items for our cloud-based application. We want each UI application to be able to inspect that API and have all the information it needs to display an accurate app-bar.

When a new application is added, existing application shouldn't have to be re-built in order to include a link to the new application in their app-bar.

If each application provides its icons as static files, and the app-bar can consume them, then the other UI apps don't nee to be re-built to provide the new link.

If each application needs an icon pack that has all the icons, then whenever a new application is developed, all existing applications need to update their version of the icon pack in order to be able to display the links to the new application.

notmessenger commented 6 years ago

👍

Approved with PullApprove

coveralls commented 6 years ago

Coverage Status

Changes Unknown when pulling 473830ffb91f7482a2bfd1818a6ffbb80b88e198 on TheOtherDude:icon-links into on ciena-frost:master.

coveralls commented 6 years ago

Coverage Status

Changes Unknown when pulling a4e630d0b3386f9bffc1dd7ef14062d861848bf0 on TheOtherDude:icon-links into on ciena-frost:master.

notmessenger commented 6 years ago

👍

Approved with PullApprove