job13er commented 7 years ago

This project uses semver, please check the scope of this pr:

[ ] #none# - documentation fixes and/or test additions
[x] #patch# - backwards-compatible bug fix
[ ] #minor# - adding functionality in a backwards-compatible manner
[ ] #major# - incompatible API change

I started cleaning this up, b/c I believed the prop types needed to be updated, because I was getting warnings in my app, but now I'm not seeing them, so I figured I'd just submit the cleanup.

CHANGELOG

Enabled code coverage checks
Enabled throwing errors when proptypes finds problems (instead of warnings)
Upgraded ember-test-utils to 5.x

coveralls commented 7 years ago

Changes Unknown when pulling 3b3dba490e3ba12c537534b0f3ab701741063be9 on job13er:fix-proptypes into on ciena-frost:master.

coveralls commented 7 years ago

Changes Unknown when pulling 12e07720c05b2cf645970c8e8c899199caf96759 on job13er:fix-proptypes into on ciena-frost:master.

coveralls commented 7 years ago

Changes Unknown when pulling e9c3d4815ba86cba912440d02f4049fe434420ea on job13er:fix-proptypes into on ciena-frost:master.

job13er commented 7 years ago

This looks like a big PR with 47 files changed, but they are all very minor changes. Mainly adding hooks where they were missing and reorganizing the propTypes sections (using a shared prop type from typedefs instead of re-defining it in multiple components, and fixing ordering of properties).

sglanzer-deprecated commented 7 years ago

Approved

ciena-frost / ember-frost-table

Fix proptypes #19

This project uses semver, please check the scope of this pr:

CHANGELOG