ciena-frost / ember-frost-table

MIT License
1 stars 9 forks source link

willDestroy() is not a public lifecycle hook #50

Open notmessenger opened 6 years ago

notmessenger commented 6 years ago

Used in https://github.com/ciena-frost/ember-frost-table/blob/master/addon/mixins/selection.js#L262

There are only willDestroyElement() and willClearRender() - https://guides.emberjs.com/v2.12.0/components/the-component-lifecycle/

willDestroy() is listed as public here - https://github.com/emberjs/ember.js/blob/629c5a8c0f20ecd69c817d5c704a8e331458fb28/packages/ember-runtime/lib/system/core_object.js#L482 - so if experience issues with the hooks in the docs maybe there was a reason this was used?