cienicera / Koji

The First Onchain Generative Music Library. Deployed on Starknet
9 stars 11 forks source link

added pitch, mode, voicing, time #18

Closed caseywescott closed 1 year ago

caseywescott commented 1 year ago

Added Mode, PitchClass, Voicing and Time utils. Voicing and Time are in progress. I am going to add some more functionality to PitchClass to better hande harmonization by Voicings. I am also going to modify Vocings to harmonize each elements from a given notebase as opposed to modal steps relative to each other, as is the case with Mode.

Pull Request type

Please check the type of change your PR introduces:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Now enables modal transposition and operations on midi keynums in harmonic contexts.

-

-

Does this introduce a breaking change?

Other information

raphaelDkhn commented 1 year ago

LGTM!