cienicera / Koji

The First Onchain Generative Music Library. Deployed on Starknet
9 stars 12 forks source link

Added extract_notes #21

Closed caseywescott closed 1 year ago

caseywescott commented 1 year ago

Iterates through MIDI events and collects all NoteOn and NoteOff messages within a specified range.

Pull Request type

Please check the type of change your PR introduces:

What is the current behavior?

Extract notes within a specified pitch range from middle c. Note range is defined as +- middlec (keynum 60). EG note_range== 12 -> 48 - 72 To enable more specific data slicing, I could imagine changing note_range to two arguments: lower_bound and upper_bound

Issue Number: #7

What is the new behavior?

-

-

Does this introduce a breaking change?

Other information

raphaelDkhn commented 1 year ago

LGTM!