Change Note Duration Implementation - Githubissues

cienicera / Koji

The First Onchain Generative Music Library. Deployed on Starknet

9 stars 11 forks source link

Change Note Duration Implementation #24

Closed caseywescott closed 1 year ago

caseywescott commented 1 year ago

Here is the link to the implementation. Any struct with a time value is scaled by the supplied factor. There could be other approaches, namely avoiding scaling for initial event so that start time is not shifted.

Pull Request type

Please check the type of change your PR introduces:

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: #8

What is the new behavior?

-

-

Does this introduce a breaking change?

[ ] Yes
[X] No

Other information

raphaelDkhn commented 1 year ago

LGTM!