cienicera / Koji

The First Onchain Generative Music Library. Deployed on Starknet
9 stars 12 forks source link

Reverse Notes #25

Closed caseywescott closed 1 year ago

caseywescott commented 1 year ago

Here is a link to the implementation.

Reverse the order of note and midi messages by finding the last and first message times, applying the following computation to every time value: (lastmsgtime - currenttime) + firstmsgtime & swap NoteOn/NoteOff msgs.

I need to append the first and last msgs to the eventlist as well.

Note: This might not be the most optimized version - Perhaps I should avoid use of the reverse function via ArrayTraitExt, SpanTraitExt?

Pull Request type

Please check the type of change your PR introduces:

What is the current behavior?

Issue Number: #5

What is the new behavior?

-

-

Does this introduce a breaking change?

Other information

raphaelDkhn commented 1 year ago

Hmm I it looks good to me! If you want to avoid using the reverse function via ArrayTraitExt, SpanTraitExt? Do you have a better way to reverse array in mind?

caseywescott commented 1 year ago

I tried a couple attempts at trying avoid the reverse but couldn't come up with anything better. This is a good start and if I can come up with something I can drop a pr...