Remap instruments - Githubissues

caseywescott commented 1 year ago

Here is the implementation.

Remap_Instruments iterates through MIDI messages and increments the Control change value argument within instrument groups.

I'm uncertain about the exact pattern to use as some devices use MSB+LSB which would require finding adjacent cc msgs prior to selecting a new instrument.

Pull Request type

Please check the type of change your PR introduces:

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: #10

What is the new behavior?

-

Does this introduce a breaking change?

[ ] Yes
[X] No

Other information

raphaelDkhn commented 1 year ago

LGTM! For the right pattern to use I think let's start with that and in the future we refactor it

caseywescott commented 1 year ago

Sounds like a plan!

cienicera / Koji

Remap instruments #26

Pull Request type

What is the current behavior?

What is the new behavior?

-

Does this introduce a breaking change?

Other information