cienicera / Koji

The First Onchain Generative Music Library. Deployed on Starknet
9 stars 11 forks source link

generate-harmony implementation w/ pitchclass fix #29

Closed caseywescott closed 1 year ago

caseywescott commented 1 year ago

Pull Request type

Lots of changes and bug fixes to implement generate-harmony that creates a new Midi with notes harmonized n steps above or below at a given tonic/pitchbase and Mode. Includes both the harmony and existing melody.

I fixed a few bugs in PitchClass so that should compile fine now once this is merged. I have a ton of tests that I will load up as well.

Please check the type of change your PR introduces:

What is the current behavior?

Issue Number: #12

What is the new behavior?

Does this introduce a breaking change?

Other information