Pitchclass 2 frequency - Githubissues

cienicera / Koji

The First Onchain Generative Music Library. Deployed on Starknet

9 stars 12 forks source link

Pitchclass 2 frequency #44

Closed caseywescott closed 8 months ago

caseywescott commented 8 months ago

This feature implements the conversion from PitchClass/Midikeynums to Frequency (Hz) Code here

Test cases currently reside here

Pull Request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ X] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Currently, decimals values aren't being included in the tests printouts. Integer freq calculations work well

Issue Number: #43

What is the new behavior?

Now PitchClassTrait can be used in Cairo-Wave creations!

-

Does this introduce a breaking change?

[ ] Yes
[X ] No

Other information