cienicera / nft-svg-onchain-multiseries

Multi Series On-chain SVG NFT contract for p5mint
Apache License 2.0
0 stars 2 forks source link

Advise on Contract Spec #5

Open caseywescott opened 2 months ago

caseywescott commented 2 months ago

Here is the Rough Spec Idea:

https://github.com/cienicera/nft-svg-onchain-multiseries/issues/4#issue-2486339988

It would be great for you to look at the data types for each field and see if they are consistent with the popular patterns seen in NFT series.

I'd also like to know if the structure of the contract looks robust. Specifically if the: (Storage (Series (ArtistMetadata, SVG data))) is the best way to structure things.

Basically red pen any weaknesses and make recommendations for a better implementation for implementing a contract that manages Series of SVG NFTs

ptisserand commented 2 months ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I'm part of Starknet ecosystem since around 2 years as a developer/contributor on several projects (starknet.dart, kakarot, madara, ark project). I know cairo development.

How I plan on tackling this issue

I will review the proposal for contract and check if there is some standard or pattern from OZ which can be usefull.

ShantelPeters commented 2 months ago

Hi @caseywescott please can I be assigned to this issue

ShantelPeters commented 2 months ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I am a blockchain developer please assign me and i will come up with a PR immediately

How I plan on tackling this issue

I will approach the problem with the following:

1. Data Type Consistency

2. Storage Structure

3. Robustness

Recommendations

onlydustapp[bot] commented 2 months ago

The maintainer caseywescott has assigned ptisserand to this issue via OnlyDust Platform. Good luck!