search

cieslarmichal / faker-cxx

C++ Faker library for generating fake (but realistic) data.
https://cieslarmichal.github.io/faker-cxx/
MIT License
301 stars 129 forks source link

Add location addresses data from Israel #459

Open cieslarmichal opened 8 months ago

SayeedKhan21 commented 8 months ago

hey @cieslarmichal I think as a first contribution I will start with this issue . I just wanted to ask how do fetch all the cities, states, prefixes accurately ? Like is there any specific website /api through which gather all this info ?

cieslarmichal commented 8 months ago

Hello, here you go: https://github.com/faker-js/faker/tree/next/src/locales/he/location

cieslarmichal commented 8 months ago

Consider giving a star to the repository to make this project more popular 🌟

SayeedKhan21 commented 7 months ago

hey @cieslarmichal could you tell me what do these folders mean ? Like what does the "he" folder here contain ?

cieslarmichal commented 7 months ago

He is for hebrew language - Israel. It contains all location data needed here.

SayeedKhan21 commented 7 months ago

do u have a reference of the same as well ? Like you mentioned he is for hebrew , similarly other folders also mean something or the other , so u like do have a file containing all such stuff/mappings ? It would be great in that case

cieslarmichal commented 7 months ago

In fakerjs in each folder there is a metadata file which contains info which country and language it s about, but I am now aware of general mapping for list of countries

SayeedKhan21 commented 7 months ago

@cieslarmichal what files are expected in israel folder in /location/data/israel ? Israelcities , Israelstates and ? . Should i take up all the related files in fakerjs he folder ? https://github.com/faker-js/faker/tree/next/src/locales/he/location

cieslarmichal commented 7 months ago

Look for example in https://github.com/cieslarmichal/faker-cxx/tree/main/src/modules/location/data/poland and add corresponding definitions but for Israel.

SayeedKhan21 commented 7 months ago

@cieslarmichal Vscode is not rendering the hebrew names properly on my system . I actually wanted to add double quotes to all names as per done in all the files and while doing so I realized that some of the names are not getting rendered properly . Any suggestions on this ?

cieslarmichal commented 7 months ago

Yes, what file encoding do you have in your file? It should be utf8 as I remember

SayeedKhan21 commented 7 months ago

Its UTF-8 itself . How do you double quote entire ts file ? Any specific method that u use ?

cieslarmichal commented 7 months ago

I dont uderstand it I guess, could you give me more detailed explaination? With examples etc

SayeedKhan21 commented 7 months ago

Can i dm you on discord ?

cieslarmichal commented 7 months ago

Sure