search

cieslarmichal / faker-cxx

C++ Faker library for generating fake (but realistic) data.
https://cieslarmichal.github.io/faker-cxx/
MIT License
222 stars 99 forks source link

fix clang tidy errors #654

Open cieslarmichal opened 2 weeks ago

cieslarmichal commented 2 weeks ago

https://github.com/cieslarmichal/faker-cxx/actions/runs/9528652077/job/26266591173

00thirdeye00 commented 3 days ago

can you give some more information about this issue?

cieslarmichal commented 3 days ago

When running clang-tidy it gives a lot of errors, I am not familiar with clang tidy much but it's static analysis of the code, It would improve our code quality. First we can add clang tidy config, for example ref its also issue for that: https://github.com/cieslarmichal/faker-cxx/issues/617

cieslarmichal commented 3 days ago

and clang tidy runs in continous integration with github workflow but it's turned off so it doesn't fail - running but fails does not fail entire pipelines