cieslarmichal / faker-cxx

C++ Faker library for generating fake (but realistic) data.
https://cieslarmichal.github.io/faker-cxx/
MIT License
297 stars 124 forks source link

build: Honor CMake USE_STD_FORMAT option #761

Closed uilianries closed 3 months ago

uilianries commented 3 months ago

Hello!

The USE_STD_FORMAT is always available, even when std::format is not available, resulting in a not desired behavior: Will ignore user decision and use fmt library instead.

This PR makes USE_STD_FORMAT available as option only when HAS_STD_FORMAT is True (fixed support for Windows).

Plus, I added a brief description about those options in the contribution guide, so people can understand what they may affect when changing those options.