cieslarmichal / faker-cxx

C++ Faker library for generating fake (but realistic) data.
https://cieslarmichal.github.io/faker-cxx/
MIT License
280 stars 109 forks source link

add missing tests for person module #810

Closed cieslarmichal closed 5 days ago

cieslarmichal commented 1 month ago

https://app.codecov.io/github/cieslarmichal/faker-cxx/blob/main/src%2Fmodules%2Fperson%2Fperson.cpp

hussein-mamane commented 1 month ago

hello, I would like to test the modules (probably not all of them), can you explain exactly what to test in them, how to proceed and the tool you want to use , maybe just test one of the modules to show how you want it done. I think it is repetitive, so I can follow your example test. It would be nice to explain your issues so I can onboard in, I am new to OpenSource . Thanks

cieslarmichal commented 1 month ago

Take a look at person source code person.cpp and person_test.cpp and then visit a link I sent, it shows covered lines with tests, so the job will be to cover lines that are red (not covered) - write additional tests in person_test file

cieslarmichal commented 1 month ago

If you have any questions related to setup join our discord channel (link in readme)

hussein-mamane commented 1 month ago

thanks

cieslarmichal commented 1 month ago

consider giving a star to the repository to make this project more popular :star:

hussein-mamane commented 1 month ago

hello, can you unassign the person.cpp test from me. I am not ready now, I am looking at the code.

cieslarmichal commented 1 month ago

Ok