ciffc-devops / ciapp

https://icscanada.ca/
3 stars 1 forks source link

NOTAM coordinate fixing #20

Closed jkatton closed 1 year ago

jkatton commented 1 year ago

silently corrects or discards entered coordinates on clicking save, would probably be better to have a popup asking if the following corrections is correct, or leave it as entered.

problem case: you enter a coordinate, it gets changed to whatever, then you realize it was wrong, go back in and enter the new one slightly incorrectly, it gets coordinate-not-okay'd, but the user never sees that it was rejected and the old one remains.

also, 12 decimal places for minutes is probably.... unnecessary. https://xkcd.com/2170/

dylancbaker commented 1 year ago

If invalid coordinates are entered, it will now prompt you and prevent you from proceeding without (a) good or (b) blank field. i've rounded the coordinates to 6 decimal places