ciffc-devops / ciapp

https://icscanada.ca/
3 stars 1 forks source link

org chart >assign role page issues #30

Closed jkatton closed 1 year ago

jkatton commented 1 year ago

image

reducing the window height hides the bottom save checkbox and assign button, should probably turn to a vertical scroll.

not clear why some fields are red, seems confusing, when last name is the only one required.

probably be better to default agency to blank. home prov and country defaulting are okay, I guess. There's no way to change the default country, which bugs me a bit... but probably safe in the expected use scenario.

Home Prov/Terr help tooltip typo.

Dietary restrictions and allergies would be more useful as a type in a-la preferred pronouns.

jkatton commented 1 year ago

further testing - I guess the red fields are required, so you need to add * to them? or change the error message to say "red fields are required", and get rid of the stars entirely.

I assume the required things have been prescribed... if not, seems like a weird bunch to choose. If someone doesn't have a cell phone... are they not allowed on site?

jkatton commented 1 year ago

for dropdowns, it's nice to have a blank option, that way if you don't know the answer, and accidentally click on it, you're not forced to pick an option that might be incorrect.

dylancbaker commented 1 year ago
jkatton commented 1 year ago

Still issue with the window sizing - I think there's also an issue with this window being too big, having too much stuff in it. It doesn't fit on my screen, and I don't have a small screen.

image

As far as solid bugs, the submit and save buttons get hidden behind other things, and there's still no vertical scrollbar.

dylancbaker commented 1 year ago

K, added a scroll bar, reduced the initial size

dylancbaker commented 1 year ago

Solved completely by removing the ability to add new people here