search

cifkao / html-midi-player

🎹 Play and display MIDI files on the web
https://cifkao.github.io/html-midi-player/
BSD 2-Clause "Simplified" License
630 stars 56 forks source link

Some notes being visualized but not played #19

Closed VG-account1 closed 2 years ago

VG-account1 commented 3 years ago

Some notes are being visualized but not played. For example the lowest note of the highest voice (purple) of passport.mid (mirrors here).

cifkao commented 3 years ago

Interesting. I tried logging the note events and I can see these notes (with pitch 89) in the log, but cannot hear them played. This must be a problem with the sound fonts used by Magenta.js (I can reproduce the issue by uploading the file to their demo), so I suggest you raise the issue there.

VG-account1 commented 3 years ago

https://github.com/magenta/magenta-js/issues/573

cifkao commented 2 years ago

@VG-account1 @majorcyto Should be fixed soon in Magenta.js! There should be no need to update html-midi-player, it should be enough to bump the @magenta/music version once it's released.

majorcyto commented 2 years ago

Hmm, it looks like they merged it into the main branch but NPM has not been updated yet. I wonder when that gets pushed. @cifkao ?

majorcyto commented 2 years ago

Edit: Oh I see someone needs to make a separate version update commit there.

cifkao commented 2 years ago

Fixed (@magenta/music@1.23.1)! I just updated https://cifkao.github.io/html-midi-player/ and the readme.