search

cifsd-team / ksmbd

ksmbd kernel server(SMB/CIFS server)
151 stars 23 forks source link

Non-english characters can not be used in share name? #515

Closed iamwudy closed 3 years ago

iamwudy commented 3 years ago

I have such config file: ====start====

/etc/ksmbd/smb.conf

[global] netbios name = SMBD

[阿] path = /SnapDisk1/阿 valid users = wudy write list = wudy ====end==== Where "阿" is a (chinese) non-english character

When I visit the ksmbd server, both in Linux & Windows clients. I got an error meaning "share list error"

If I change the config file as: ====start====

/etc/ksmbd/smb.conf

[global] netbios name = SMBD

[aaa] path = /SnapDisk1/阿 valid users = wudy write list = wudy ====end==== The error will disappear, and I will see the share folder "aaa"

If I change the config file as: ====start====

/etc/ksmbd/smb.conf

[global] netbios name = SMBD

[ん] path = /SnapDisk1/阿 valid users = wudy write list = wudy ====end==== Where "ん" is a (japanese) non-english character The error appears again

Environment: Arch: x86_64 OS: Centos 8 Kernel: 5.4.44

I have checked that: smb.conf is in UTF-8 and UTF-8 charset had compiled in kernel And I have tested that the error is not in account/password phase

namjaejeon commented 3 years ago

@hclee Hyunchul, Can you take a look ?

hclee commented 3 years ago

Okay, I will take a look at this problem.

2021년 4월 23일 (금) 오전 8:39, Namjae Jeon @.***>님이 작성:

@hclee https://github.com/hclee Hyunchul, Can you take a look ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cifsd-team/cifsd/issues/515#issuecomment-825269264, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3ZTCAHLHJXXQFAABKETEDTKCXSXANCNFSM43LTJHYQ .

namjaejeon commented 3 years ago

@iamwudy Hi, Can you check your problem is fixed with #ksmbd-tools-next branch ? git clone --branch=ksmbd-tools-next https://github.com/cifsd-team/ksmbd-tools

iamwudy commented 3 years ago

I will check it as quickly.

iamwudy commented 3 years ago

It works! I have checked some Chinese, Korean and Japanese characters with listing $IPC and creating in share. But I can't ensure that it works on all characters. (Such as Greek)

namjaejeon commented 3 years ago

Thanks for your check!! If you paste Greek word you tested here, @hclee will check it.

hclee commented 3 years ago

@iamwudy If you have problem with some languages, let me know these.