search

cifsd-team / ksmbd

ksmbd kernel server(SMB/CIFS server)
151 stars 23 forks source link

Do not set SMB2_GLOBAL_CAP_ENCRYPTION for SMB 3.1.1. Fixes #550 #551

Closed socram8888 closed 2 years ago

socram8888 commented 2 years ago

According to the official Microsoft MS-SMB2 document section 3.3.5.4, this flag should be used only for 3.0 and 3.0.2 dialects. Setting it for 3.1.1 is a violation of the specification.

This caused Windows 10 to detect a mistake in the protocol, and disable encryption despite being enabled in the settings.

hclee commented 2 years ago

Could you send this patch to linux-cifs@vger.kernel.org? And the prefix, "ksmbd: " has to be added to the commit title.

socram8888 commented 2 years ago

I've just sent the patch to the LKML, so I am gonna close this PR :)