search

cigraphics / chrome-screen-capture

Automatically exported from code.google.com/p/chrome-screen-capture
0 stars 0 forks source link

Multi-monitors not supported #140

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. use multiple monitors 
2. Load website in browser on non-primary screen
3. When capturing screen region only primary screen has selector tools

What is the expected output? What do you see instead?
I expected to see the selector on my second monitor but not. I even tried 
dragging on the second monitor but that didn't work

What version of the product are you using? On what operating system?
Very latest version of the product...I just installed it today. Windows 7 Pro 
with latest updates.

Please provide any additional information below.

Original issue reported on code.google.com by mbgilb...@gmail.com on 30 Jun 2011 at 12:43

GoogleCodeExporter commented 9 years ago 
Further to my bug post, this is specifically related to the button "Capture 
Screen Region" and NOT "Capture Visible Content" or "Capture Page Region".

Original comment by mbgilb...@gmail.com on 30 Jun 2011 at 12:46

GoogleCodeExporter commented 9 years ago 
Same problem exactly.  Only works on Primary monitor, not 2nd one.

Original comment by Jesse.Sc...@gmail.com on 30 Jun 2011 at 2:40

GoogleCodeExporter commented 9 years ago 
I met the same issue when selecting "Capture Screen Region". Multiple monitor 
support is preferred.

Original comment by xiaochun...@gmail.com on 17 Jan 2013 at 3:17

GoogleCodeExporter commented 9 years ago 
Just making changes at 2 places to support multiple monitor. Please see the 
following code snippet:

File capture_window.cc, method bool CaptureWindow::Init(), line #28:
change from:
  GetWindowRect(desktop_hwnd, &rect);
  window_width_ = rect.right - rect.left;
  window_height_ = rect.bottom - rect.top;

to:
  if(GetSystemMetrics(SM_CMONITORS) > 1){
    window_width_ = ::GetSystemMetrics(SM_CXVIRTUALSCREEN);
    window_height_ = ::GetSystemMetrics(SM_CYVIRTUALSCREEN);

  }
  else{
    GetWindowRect(desktop_hwnd, &rect);
    window_width_ = rect.right - rect.left;
    window_height_ = rect.bottom - rect.top;
  }

File screen_capture_plugin.cc, method INT_PTR CALLBACK Preview(...), line #99 ~ 
line #103,

change to:
      RECT rect;
      int windowWidth;
      int windowHeight;

      if(GetSystemMetrics(SM_CMONITORS) > 1){
         rect.left = ::GetSystemMetrics(SM_XVIRTUALSCREEN);
     rect.top = ::GetSystemMetrics(SM_YVIRTUALSCREEN);
         windowWidth = ::GetSystemMetrics(SM_CXVIRTUALSCREEN);
     windowHeight = ::GetSystemMetrics(SM_CYVIRTUALSCREEN);
      }
      else{
        GetWindowRect(GetDesktopWindow(), &rect);
        windowWidth = rect.right - rect.left;
        windowHeight = rect.bottom - rect.top;
      }

      SetWindowPos(hDlg, HWND_TOPMOST, 
                   rect.left, rect.top, windowWidth, 
                   windowHeight, SWP_SHOWWINDOW|SWP_NOREDRAW);

Original comment by xiaochun...@gmail.com on 17 Jan 2013 at 5:52

Attachments:

GoogleCodeExporter commented 9 years ago 
Same issue on Macbook Pro OSX v 10.9.X

Original comment by lucasopt...@gmail.com on 27 Dec 2013 at 1:54