cihai / unihan-etl

Export UNIHAN's database to csv, json or yaml
https://unihan-etl.git-pull.com
MIT License
52 stars 13 forks source link

Fix for `Options.destination` path not replacing extension #285

Closed tony closed 1 year ago

tony commented 1 year ago

fix(Options): Fix path to Options.destination to follow Options.format

codecov[bot] commented 1 year ago

Codecov Report

Merging #285 (f632d6d) into master (aef7fb3) will decrease coverage by 0.04%. The diff coverage is 25.00%.

:exclamation: Current head f632d6d differs from pull request most recent head acae600. Consider uploading reports for the commit acae600 to get more accurate results

@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
- Coverage   69.45%   69.41%   -0.04%     
==========================================
  Files          10       10              
  Lines        1005     1007       +2     
  Branches      182      182              
==========================================
+ Hits          698      699       +1     
- Misses        282      283       +1     
  Partials       25       25              
Impacted Files Coverage Δ
tests/test_unihan.py 96.55% <ø> (ø)
src/unihan_etl/options.py 5.00% <25.00%> (+5.00%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more