search

cihai / unihan-etl

Export UNIHAN's database to csv, json or yaml
https://unihan-etl.git-pull.com
MIT License
52 stars 13 forks source link

v0.21.x: Fix for `DEFAULT_OPTIONS['destination']` path not replacing extension #286

Closed tony closed 1 year ago

tony commented 1 year ago

Backport of #285 to v0.21.x

fix(Options): Fix path to Options.destination to follow Options.format

codecov[bot] commented 1 year ago

Codecov Report

Merging #286 (83dc7bd) into v0.21.x (9be7980) will increase coverage by 0.01%. The diff coverage is 100.00%.

:exclamation: Current head 83dc7bd differs from pull request most recent head c6db5eb. Consider uploading reports for the commit c6db5eb to get more accurate results

@@             Coverage Diff             @@
##           v0.21.x     #286      +/-   ##
===========================================
+ Coverage    93.30%   93.32%   +0.01%     
===========================================
  Files           14       14              
  Lines         1045     1048       +3     
  Branches       175      175              
===========================================
+ Hits           975      978       +3     
  Misses          51       51              
  Partials        19       19
Impacted Files Coverage Δ
src/unihan_etl/process.py 85.65% <100.00%> (+0.06%) :arrow_up:
src/unihan_etl/types.py 93.54% <100.00%> (ø)
tests/test_unihan.py 96.53% <100.00%> (+0.04%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more