search

cihologramas / pyoptools

Python tools for optical design
GNU General Public License v3.0
137 stars 46 forks source link

Changed method for rotating surfaces in plot3d #131

Closed rdgraham closed 1 year ago

rdgraham commented 1 year ago

As discussed in issue #130 Seems to fix the 3D display surface rotation issue.

semiversus commented 1 year ago

Doing the rotation step by step seems to be a good idea. The order of doing all the rotations in one step is depending on the used library (and so you have to look it up, what is the order).

You should remove the commented-out code.

ramezquitao commented 1 year ago

I think @semiversus suggestion to clean up the code before merging is the best to do. However, for the moment I will accept the pull request as it is really important to be able to get good 3d plots. I will try to establish some set of rules for the next pull requests.