[this was in aspheres_library PR, moved to separate PR since not related.]
Bug fix : fixed material type not being applied to Component instances by optic_factory when the material is not explicitly required by the constructor (this had affected SphericalLens instances loaded from the component library).
I think strictly the better design would be to not have the material argument in Component constructor and then fix SphericalLens (and any others) to explicitly take the material keyword argument. After all, not all possible components have a relevant material (e.g. optic stops).
I wasn't sure if that would have some other consequences so just fixed it this way for now.
[this was in aspheres_library PR, moved to separate PR since not related.]
I think strictly the better design would be to not have the material argument in Component constructor and then fix SphericalLens (and any others) to explicitly take the material keyword argument. After all, not all possible components have a relevant material (e.g. optic stops).
I wasn't sure if that would have some other consequences so just fixed it this way for now.